server,ui: show internal stats with new cluster setting#86679
server,ui: show internal stats with new cluster setting#86679craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
Previously, we were not showing internal results on fingerprint options on SQL Activity. A new cluster setting created `sql.stats.response.show_internal` can be set to `true` and internal statistics will be displayed on SQL Activity page. Fixes cockroachdb#79547 Release justification: low risk, high benefit change Release note (sql change): New cluster setting `sql.stats.response.show_internal` with default value of `false` can be set to true, to display information about internal stats on SQL Activity page, with fingerprint option.
fee386a to
3750821
Compare
rafiss
left a comment
There was a problem hiding this comment.
this is great, thanks! what do you think about making the setting default to true? my understanding is that only a small minority of clusters require the queries to be hidden.
|
@rafiss we received feedback from external customers they wanted this value hidden, and from internal users that they wanted to see this info. It's a lot easier to tell everyone at CRL this cluster setting exists and that you can use to debug, to make the customers having to change the setting to have the behaviour they prefer. For that reason, I'll keep the default as false and share internally about this new cluster setting. Also, this information can always be accessed through the tables directly, without the need of the UI. |
rafiss
left a comment
There was a problem hiding this comment.
ok, sounds good to me. thanks for explaining
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 3750821 to blathers/backport-release-22.1-86679: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, we were not showing internal results on
fingerprint options on SQL Activity.
A new cluster setting created
sql.stats.response.show_internalcan be set to
trueand internal statistics will bedisplayed on SQL Activity page.
Fixes #79547
https://www.loom.com/share/1b89ba99a7c247edadb5c8b0d127755c
Release justification: low risk, high benefit change
Release note (sql change): New cluster setting
sql.stats.response.show_internalwith default value offalsecan be set to true, to display information about internal stats
on SQL Activity page, with fingerprint option.