Skip to content

kvserver: add additional testing to multiqueue#86630

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
AlexTalks:mq_test
Aug 26, 2022
Merged

kvserver: add additional testing to multiqueue#86630
craig[bot] merged 1 commit intocockroachdb:masterfrom
AlexTalks:mq_test

Conversation

@AlexTalks
Copy link
Copy Markdown
Contributor

@AlexTalks AlexTalks commented Aug 23, 2022

Add testing for cancelation of multi-queue requests
and fix a bug where the channel wasn't closed on task
cancelation.

Release justification: Test-only change.
Release note: None

@AlexTalks AlexTalks requested a review from a team as a code owner August 23, 2022 03:07
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Add testing for cancelation of multi-queue requests
and fix a bug where the channel wasn't closed on task
cancelation.

Release justification: Test-only change.
Release note: None
Copy link
Copy Markdown

@andrewbaptist andrewbaptist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexTalks
Copy link
Copy Markdown
Contributor Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 26, 2022

Build succeeded:

@craig craig bot merged commit 3688055 into cockroachdb:master Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants