distsql: finish the tracing span later in an error case#86618
distsql: finish the tracing span later in an error case#86618craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Previously, it was possible to run the finished tracing span when setting up the remote DistSQL flow if that setup encounters an error. In such a scenario, we need to clean up the resources explicitly, and the order of that cleanup was incorrect - we would finish the span before possibly using the context that is still referencing the finished span. This is now fixed. Release justification: bug fix. Release note: None
|
This change is |
michae2
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @cucaroach)
|
TFTR! bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from ebde53c to blathers/backport-release-22.1-86618: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Previously, it was possible to run the finished tracing span when
setting up the remote DistSQL flow if that setup encounters an error. In
such a scenario, we need to clean up the resources explicitly, and the
order of that cleanup was incorrect - we would finish the span before
possibly using the context that is still referencing the finished span.
This is now fixed.
Fixes: #86369.
Release justification: bug fix.
Release note: None