Skip to content

sql: add nil guard when formatting placeholders#86607

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-placeholder-format
Aug 25, 2022
Merged

sql: add nil guard when formatting placeholders#86607
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-placeholder-format

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Aug 22, 2022

Fixes #85363

Release note (bug fix): Fixed a crash that could happen when formatting
queries that have placeholder BitArray arguments.

Release justification: Fix a panic.

Release note (bug fix): Fixed a crash that could happen when formatting
queries that have placeholder BitArray arguments.

Release note: Fix a panic.
@rafiss rafiss requested review from a team and ZhouXing19 August 22, 2022 20:00
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Aug 23, 2022

tftr!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 23, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 23, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 23, 2022

Build failed:

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Aug 24, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 25, 2022

Build succeeded:

@craig craig bot merged commit 2787ff1 into cockroachdb:master Aug 25, 2022
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Aug 25, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from cfc445a to blathers/backport-release-21.2-86607: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


error creating merge commit from cfc445a to blathers/backport-release-22.1-86607: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: v22.1.5: nil pointer when formatting DBitArray

3 participants