Skip to content

builtins: don't panic on placeholders in bounded staleness function#86605

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-placeholder-bounded-staleness
Aug 25, 2022
Merged

builtins: don't panic on placeholders in bounded staleness function#86605
craig[bot] merged 1 commit intocockroachdb:masterfrom
rafiss:fix-placeholder-bounded-staleness

Conversation

@rafiss
Copy link
Copy Markdown
Collaborator

@rafiss rafiss commented Aug 22, 2022

fixes #86243

Release note (bug fix): Fixed a crash/panic that could occur if
placeholder arguments were used with the with_min_timestamp or
with_max_staleness functions.

Release justification: Fix a crash caused by a panic.

Release note (bug fix): Fixed a crash/panic that could occur if
placeholder arguments were used with the with_min_timestamp or
with_max_staleness functions.

Release justification: Fix a crash caused by a panic.
@rafiss rafiss requested review from a team and RichardJCai August 22, 2022 19:42
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@rafiss rafiss changed the title builtins: don't panic on placeholders in boudned staleness function builtins: don't panic on placeholders in bounded staleness function Aug 22, 2022
@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Aug 23, 2022

tftr!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 23, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 23, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 23, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 23, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 24, 2022

Build failed:

@rafiss
Copy link
Copy Markdown
Collaborator Author

rafiss commented Aug 24, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 24, 2022

Build failed (retrying...):

@craig craig bot merged commit 2787ff1 into cockroachdb:master Aug 25, 2022
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 25, 2022

Build succeeded:

@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Aug 25, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from 34f6bf9 to blathers/backport-release-21.2-86605: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 21.2.x failed. See errors above.


error creating merge commit from 34f6bf9 to blathers/backport-release-22.1-86605: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@rafiss rafiss deleted the fix-placeholder-bounded-staleness branch August 26, 2022 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: v22.1.1: expected *DTimestampTZ, found *tree.Placeholder for with_min_timestamp

3 participants