scbuildstmt: added cluster version gating for declarative schema changer#86604
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Aug 25, 2022
Merged
Conversation
Member
|
This change is |
58a1ac8 to
809fc14
Compare
ajwerner
approved these changes
Aug 22, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 2 of 5 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
This check is redundant with what follows it.
For each implemented DDL stmt in the new schema changer, we added a minimal supported cluster version so that we can return an unimplemented error when the cluster version is lower than the minimal supported cluster version of that DDL statement. This will be useful in mixed-version cluster where we make sure we don't use new schema changer for statements that are only supported in v22.2, but not in v22.1. Release justification: improve safety and prevent issues in mixed-version cluster. Release note: None
809fc14 to
af1b9c4
Compare
Contributor
|
still LGTM |
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For each implemented DDL stmt in the new schema changer, we added a
minimal supported cluster version so that we can return an unimplemented
error when the cluster version is lower than the minimal supported
cluster version of that DDL statement.
This will be useful in mixed-version cluster where we make sure we don't
use new schema changer for statements that are only supported in v22.2,
but not in v22.1.
Partially fix #79840
Release justification: improve safety and prevent issues in
mixed-version cluster.
Release note: None