spanconfigtestutils: copy gc job testing knobs to tenant#86558
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 25, 2022
Merged
spanconfigtestutils: copy gc job testing knobs to tenant#86558craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Some of the sqltranslator tests require that we can disable the GC job related to an index creation so that we can observe the span configuration on the temporary indexes. We pause the GC job via a testing knob. Release justification: Test-only change Release note: None
Member
|
This change is |
ajwerner
approved these changes
Aug 23, 2022
Contributor
ajwerner
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @stevendanna)
Contributor
|
I'm borsing this. The flakes are real 🥐 bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Collaborator
Author
|
bors retry |
Contributor
|
Build failed (retrying...): |
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the sqltranslator tests require that we can disable the GC job
related to an index creation so that we can observe the span
configuration on the temporary indexes. We pause the GC job via a
testing knob.
Fixes #85507
Release justification: Test-only change
Release note: None