storage: improve ComputeStats performance#86515
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Aug 22, 2022
Merged
storage: improve ComputeStats performance#86515craig[bot] merged 2 commits intocockroachdb:masterfrom
ComputeStats performance#86515craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
This patch omits a `sort.Search()` call during `ComputeStats()` when possible, which essentially recovers the remaining no-range-key regression since 22.1. ``` name old time/op new time/op delta MVCCComputeStats_Pebble/valueSize=32/numRangeKeys=0-24 156ms ± 1% 145ms ± 1% -7.28% (p=0.000 n=10+10) MVCCComputeStats_Pebble/valueSize=32/numRangeKeys=1-24 190ms ± 1% 178ms ± 1% -6.24% (p=0.000 n=10+10) MVCCComputeStats_Pebble/valueSize=32/numRangeKeys=100-24 210ms ± 1% 187ms ± 1% -10.89% (p=0.000 n=10+10) ``` Release justification: bug fixes and low-risk updates to new functionality Release note: None
Member
|
This change is |
Release justification: bug fixes and low-risk updates to new functionality Release note: None
5 tasks
Contributor
Author
|
TFTR! bors r=aliher1911 |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch omits a
sort.Search()call duringComputeStats()whenpossible, which essentially recovers the remaining no-range-key
regression since 22.1.
Resolves #84544.
Release justification: bug fixes and low-risk updates to new functionality
Release note: None