Skip to content

Makefile: fix logpb generation#86481

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/fix-makefile
Aug 19, 2022
Merged

Makefile: fix logpb generation#86481
craig[bot] merged 1 commit intocockroachdb:masterfrom
ajwerner:ajwerner/fix-makefile

Conversation

@ajwerner
Copy link
Copy Markdown
Contributor

We needed to pass the flag. This will hit problems if any of the deps of the
file change.

Release justification: fixes the build

Release note: None

We needed to pass the flag. This will hit problems if any of the deps of the
file change.

Release justification: fixes the build

Release note: None
@ajwerner ajwerner requested a review from a team as a code owner August 19, 2022 19:47
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

Copy link
Copy Markdown
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)

@nicktrav
Copy link
Copy Markdown
Collaborator

bors r=nicktrav

@nicktrav
Copy link
Copy Markdown
Collaborator

bors single on

@nicktrav
Copy link
Copy Markdown
Collaborator

bors p=99

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 19, 2022

Build succeeded:

@craig craig bot merged commit 6a51183 into cockroachdb:master Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants