Skip to content

vendor: bump Pebble to 406c1dce54c9#86471

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:jackson/pebble-master-406c1dce54c9
Aug 19, 2022
Merged

vendor: bump Pebble to 406c1dce54c9#86471
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:jackson/pebble-master-406c1dce54c9

Conversation

@jbowens
Copy link
Copy Markdown
Contributor

@jbowens jbowens commented Aug 19, 2022

406c1dce *: add simpleLevelIterator, reduce merging levels in external iter
cd7f076e metamorphic: reposition iterator after SetOptions
5f6b4325 db: make RangeKeyMasking.Filter a constructor function

In addition to the vendor bump, this commit makes some small code
changes in response to interface changes within Pebbe. I kept these
changes minimal for the Pebble bump PR, and we can follow up with
fully adapting call sites to take advantage of the new ability to pass
'levels' of sstables into the sstable iterator.

Release note: None
Release justification: Non-production code changes, low-risk updates to
new functionality.

```
406c1dce *: add simpleLevelIterator, reduce merging levels in external iter
cd7f076e metamorphic: reposition iterator after SetOptions
5f6b4325 db: make RangeKeyMasking.Filter a constructor function
```

In addition to the vendor bump, this commit makes some small code
changes in response to interface changes within Pebbe. I kept these
changes minimal for the Pebble bump PR, and we can follow up with
fully adapting call sites to take advantage of the new ability to pass
'levels' of sstables into the sstable iterator.

Release note: None
Release justification: Non-production code changes, low-risk updates to
new functionality.
@jbowens jbowens requested a review from a team as a code owner August 19, 2022 18:31
@jbowens jbowens requested a review from a team August 19, 2022 18:31
@jbowens jbowens requested a review from a team as a code owner August 19, 2022 18:31
@jbowens jbowens requested a review from stevendanna August 19, 2022 18:31
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@jbowens jbowens requested review from itsbilal and msbutler August 19, 2022 18:32
Copy link
Copy Markdown
Contributor

@itsbilal itsbilal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @msbutler and @stevendanna)

Copy link
Copy Markdown
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @msbutler and @stevendanna)

@jbowens
Copy link
Copy Markdown
Contributor Author

jbowens commented Aug 19, 2022

tftrs!

bors r=itsbilal,nicktrav

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 19, 2022

Build succeeded:

@craig craig bot merged commit 6a51183 into cockroachdb:master Aug 19, 2022
@jbowens jbowens deleted the jackson/pebble-master-406c1dce54c9 branch August 19, 2022 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants