insights: surface suboptimal plans and failed executions#86458
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 19, 2022
matthewtodd:insights-suboptimal-plan-failed
Merged
insights: surface suboptimal plans and failed executions#86458craig[bot] merged 1 commit intocockroachdb:masterfrom matthewtodd:insights-suboptimal-plan-failed
craig[bot] merged 1 commit intocockroachdb:masterfrom
matthewtodd:insights-suboptimal-plan-failed
Conversation
Member
|
This change is |
matthewtodd
commented
Aug 19, 2022
Author
matthewtodd
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
pkg/sql/sqlstats/insights/problems.go line 28 at r1 (raw file):
} if stmt.Status == "failed" {
@j82w this makes me want to change Status to an enum. Okay if I do that here?
Fixes #85827. We incidentally also pluralize `Statement.IndexRecommendations` and make `Statement.Status` an enum. Release justification: Category 2: Bug fixes and low-risk updates to new functionality. Release note: None
maryliag
approved these changes
Aug 19, 2022
Contributor
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 6 of 6 files at r2, all commit messages.
Reviewable status:
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #85827.
Release justification: Category 2: Bug fixes and low-risk updates to new
functionality.
Release note: None