opt: reduce allocations in OrderingSet.LongestCommonPrefix#86443
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 19, 2022
Merged
Conversation
Previously, the `*OrderingChoice` returned by `LongestCommonPrefix` was allocated on the heap (except in the case where the ordering set contained a ordering choice that implies the given ordering). Now, `LongestCommonPrefix` returns a non-pointer type and avoids these allocations. Release justification: This is a minor change that improves performance. Release note: None
Member
|
This change is |
Contributor
Author
|
This provides a fairly significant improvement to the slow queries benchmarks: |
rytaft
approved these changes
Aug 19, 2022
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Wow nice improvement!
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @DrewKimball and @michae2)
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the
*OrderingChoicereturned byLongestCommonPrefixwasallocated on the heap (except in the case where the ordering set
contained a ordering choice that implies the given ordering). Now,
LongestCommonPrefixreturns a non-pointer type and avoids theseallocations.
Release justification: This is a minor change that improves performance.
Release note: None