Skip to content

sql: bump memory limits in a couple of tests#86426

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:fix-mem-test
Aug 19, 2022
Merged

sql: bump memory limits in a couple of tests#86426
craig[bot] merged 1 commit intocockroachdb:masterfrom
yuzefovich:fix-mem-test

Conversation

@yuzefovich
Copy link
Copy Markdown
Member

This commit is similar to dd82d13 where
we bumped --max-sql-memory limit. We have recently started hitting the
memory limit flakes again (because we do more accounting and have more
internal queries), so this commit bumps up the limits significantly
while still preserving the tests' spirit.

Fixes: #86372.

Release justification: test-only change.

Release note: None

This commit is similar to dd82d13 where
we bumped --max-sql-memory limit. We have recently started hitting the
memory limit flakes again (because we do more accounting and have more
internal queries), so this commit bumps up the limits significantly
while still preserving the tests' spirit.

Release justification: test-only change.

Release note: None
@yuzefovich yuzefovich requested review from a team and michae2 August 18, 2022 22:47
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@yuzefovich
Copy link
Copy Markdown
Member Author

No flakes in 18 minutes of stress:

8219 runs so far, 0 failures, over 18m15s

Copy link
Copy Markdown
Collaborator

@michae2 michae2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Copy Markdown
Member Author

TFTR!

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 19, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 19, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 19, 2022

Build succeeded:

@craig craig bot merged commit 6a51183 into cockroachdb:master Aug 19, 2022
@yuzefovich yuzefovich deleted the fix-mem-test branch August 19, 2022 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

sql: TestAggregatesMonitorMemory failed

3 participants