Skip to content

grunning: improve some tests#86185

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:220815.grunning-review
Aug 16, 2022
Merged

grunning: improve some tests#86185
craig[bot] merged 1 commit intocockroachdb:masterfrom
irfansharif:220815.grunning-review

Conversation

@irfansharif
Copy link
Copy Markdown
Contributor

Release note: None
Release justification: test-only changes

@irfansharif irfansharif requested a review from a team as a code owner August 15, 2022 22:38
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@irfansharif irfansharif force-pushed the 220815.grunning-review branch from 8735beb to 6f68fc3 Compare August 15, 2022 22:47
Copy link
Copy Markdown
Collaborator

@sumeerbhola sumeerbhola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @irfansharif)


pkg/util/grunning/enabled_test.go line 143 at r1 (raw file):

	defer runtime.GOMAXPROCS(runtime.GOMAXPROCS(1))

	// Create a CPU hog.

Maybe something like the following?
// Create a CPU hog. It makes the two goroutines that want to cycle between running and waiting also have to wait in runnable state, until the CPU hog is finished with its time slice.


pkg/util/grunning/enabled_test.go line 165 at r1 (raw file):

		}
		pingern = grunning.Time().Nanoseconds()
		close(stop)

// Stop the CPU hog.


pkg/util/grunning/enabled_test.go line 176 at r1 (raw file):

	}()
	ping <- true // start ping-pong
	<-stop       // wait for the pinger to finish

// wait until the pinger tells the CPU hog to finish

(the <-done are waiting for the pinger, ponger and CPU hog to actually finish, IIUC)

Release note: None
Release justification: test-only changes
@irfansharif irfansharif force-pushed the 220815.grunning-review branch from 6f68fc3 to 0ee5479 Compare August 16, 2022 15:05
@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r+

@irfansharif
Copy link
Copy Markdown
Contributor Author

bors r-

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 16, 2022

Canceled.

@irfansharif
Copy link
Copy Markdown
Contributor Author

I don't really understand the "No pass/skip/fail event found for test" failure in the extended CI but I think it's optional. The Github CI + Bazel Essential CI pass so I'm just going to bors this.

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 16, 2022

Build succeeded:

@craig craig bot merged commit 7c38417 into cockroachdb:master Aug 16, 2022
@irfansharif irfansharif deleted the 220815.grunning-review branch August 16, 2022 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants