Skip to content

vendor: bump Pebble to 84fa6a019ed4#86064

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:jackson/pebble-master-84fa6a019ed4
Aug 13, 2022
Merged

vendor: bump Pebble to 84fa6a019ed4#86064
craig[bot] merged 1 commit intocockroachdb:masterfrom
jbowens:jackson/pebble-master-84fa6a019ed4

Conversation

@jbowens
Copy link
Copy Markdown
Contributor

@jbowens jbowens commented Aug 12, 2022

84fa6a01 db: add Metrics.Keys.RangeKeySetsCount
f4b082db db: avoid defragmenting beyond prefix bounds during prefix iteration
c135b6df metamorphic: use pointer receiver

Release note: None

@jbowens jbowens requested review from a team as code owners August 12, 2022 21:57
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@jbowens jbowens requested a review from erikgrinaker August 12, 2022 21:58
Copy link
Copy Markdown
Contributor

@erikgrinaker erikgrinaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

```
84fa6a01 db: add Metrics.Keys.RangeKeySetsCount
f4b082db db: avoid defragmenting beyond prefix bounds during prefix iteration
c135b6df metamorphic: use pointer receiver
```

Release note: None
@jbowens jbowens force-pushed the jackson/pebble-master-84fa6a019ed4 branch from 069d4cf to d94f32c Compare August 12, 2022 22:10
Copy link
Copy Markdown
Collaborator

@nicktrav nicktrav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 7 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @jbowens)

@jbowens
Copy link
Copy Markdown
Contributor Author

jbowens commented Aug 12, 2022

TFTRs!

bors r=erikgrinaker,nicktrav

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 13, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 13, 2022

Build failed (retrying...):

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Aug 13, 2022

Build succeeded:

@craig craig bot merged commit 924bb83 into cockroachdb:master Aug 13, 2022
@jbowens jbowens deleted the jackson/pebble-master-84fa6a019ed4 branch August 13, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants