tree: harden constant resolution#85966
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 16, 2022
Merged
Conversation
This commit makes it so that the resolution of `NumVal` constants is done at most once for each possible type in all code paths. The idea is that the first time we resolve the value as a particular type, we memorize the resolved value (which we were already doing previously) and memorize the fact that the resolution to that particular type has been done previously. Since the `NumVal` expressions should not change, the next we need to do its resolution, we can just the cached value directly. This required splitting out int64 and int32 to use different datums under the hood since the resolution of those two types can be different (with values outside of int32 range). Release note: None
Member
|
This change is |
DrewKimball
approved these changes
Aug 15, 2022
Collaborator
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @mgartner)
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit makes it so that the resolution of
NumValconstants isdone at most once for each possible type in all code paths. The idea is
that the first time we resolve the value as a particular type, we
memorize the resolved value (which we were already doing previously) and
memorize the fact that the resolution to that particular type has been
done previously. Since the
NumValexpressions should not change, thenext time we need to do its resolution, we can just the cached value
directly. This required splitting out int64 and int32 to use different
datums under the hood since the resolution of those two types can be
different (with values outside of int32 range).
Fixes: #85934.
Release note: None