externalconn: add gs support to External Connections#85964
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 16, 2022
Merged
externalconn: add gs support to External Connections#85964craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
7c5d29f to
db6877a
Compare
Contributor
Author
|
Commit 3 is the only new one. |
13 tasks
db6877a to
8f65cba
Compare
Contributor
Author
|
@rhu713 @benbardin this should be easier to review now. I'll run our nightly unit test job to ensure it succeeds before merging. |
b1678b1 to
33550ce
Compare
This change registers Google Storage `gs` as a supported External Connection. Release note (sql change): Users can now `CREATE EXTERNAL CONNECTION` to represent an underlying google storage resource.
33550ce to
2b4f176
Compare
Contributor
Author
rhu713
approved these changes
Aug 15, 2022
Contributor
Author
|
TFTR! bors r=rhu713 |
Contributor
|
This PR was included in a batch that successfully built, but then failed to merge into master. It will not be retried. Additional information: {"message":"1 review requesting changes and 1 approving review by reviewers with write access.","documentation_url":"https://docs.github.com/articles/about-protected-branches"} |
Contributor
Author
|
bors r=rhu713 |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change registers Google Storage
gsas a supportedExternal Connection.
Release note (sql change): Users can now
CREATE EXTERNAL CONNECTIONto represent an underlyinggoogle storage resource.
Release justification: low risk change to new functionality around External Connections