sql/catalog/typedesc: fix bug which partially hydrated a type#85940
Conversation
In rare cases where we hit an error hydrating the contained type of an array alias type, we'd populate the name, but not the contents. Release note (bug fix): Fixed a rare bug where errors could occur related to the use of arrays of enums.
|
This change is |
fqazi
left a comment
There was a problem hiding this comment.
One question below for curiosity.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @ajwerner)
pkg/sql/catalog/typedesc/type_desc.go line 898 at r1 (raw file):
elemType := typ.ArrayContents() if err := EnsureTypeIsHydrated(ctx, elemType, res); err != nil { return err
Does this mean we are also ignoring errors somewhere? Or is it just a side effect of mutating the descriptor and caching?
ajwerner
left a comment
There was a problem hiding this comment.
TFTR!
bors r=fqazi
Reviewable status:
pkg/sql/catalog/typedesc/type_desc.go line 898 at r1 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
Does this mean we are also ignoring errors somewhere? Or is it just a side effect of mutating the descriptor and caching?
I don't think we were ignoring these errors, no.
|
|
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 6b37080 to blathers/backport-release-21.2-85940: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
In rare cases where we hit an error hydrating the contained type of an
array alias type, we'd populate the name, but not the contents.
Fixes #85376
Release note (bug fix): Fixed a rare bug where errors could occur related
to the use of arrays of enums.