storage: load pebbleMVCCScanner position when enabling point synthesis#85710
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 9, 2022
Merged
Conversation
Member
|
This change is |
pebbleMVCCScanner position when enabling point synthesis
a6c261c to
37b24a7
Compare
jbowens
approved these changes
Aug 8, 2022
Contributor
jbowens
left a comment
There was a problem hiding this comment.
🚀
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)
37b24a7 to
b8d90ce
Compare
This patch loads the current iterator position when switching to point synthesis in `pebbleMVCCScanner`, rather than initializing the point synthesizing iterator using an additional seek. An attempt was also made at pooling the `pointSynthesizingIter` together with the `pebbleMVCCScanner` instead of using a separate pool, but this didn't appear to have a significant effect on performance. ``` name old time/op new time/op delta MVCCGet_Pebble/batch=true/versions=1/valueSize=8/numRangeKeys=0-24 2.74µs ± 1% 2.76µs ± 1% +0.84% (p=0.013 n=10+10) MVCCGet_Pebble/batch=true/versions=1/valueSize=8/numRangeKeys=1-24 5.40µs ± 2% 3.57µs ± 1% -33.86% (p=0.000 n=10+10) MVCCGet_Pebble/batch=true/versions=1/valueSize=8/numRangeKeys=100-24 171µs ± 2% 166µs ± 1% -2.40% (p=0.000 n=9+10) MVCCGet_Pebble/batch=true/versions=10/valueSize=8/numRangeKeys=0-24 3.90µs ± 0% 3.90µs ± 1% ~ (p=0.968 n=9+10) MVCCGet_Pebble/batch=true/versions=10/valueSize=8/numRangeKeys=1-24 7.11µs ± 1% 5.13µs ± 1% -27.87% (p=0.000 n=10+10) MVCCGet_Pebble/batch=true/versions=10/valueSize=8/numRangeKeys=100-24 179µs ± 1% 174µs ± 1% -2.52% (p=0.000 n=10+10) ``` Release note: None
b8d90ce to
ce222fe
Compare
Contributor
Author
|
bors r=jbowens |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch loads the current iterator position when switching to point
synthesis in
pebbleMVCCScanner, rather than initializing the pointsynthesizing iterator using an additional seek.
An attempt was also made at pooling the
pointSynthesizingItertogetherwith the
pebbleMVCCScannerinstead of using a separate pool, but thisdidn't appear to have a significant effect on performance.
Resolves #84380.
Release note: None