acceptance: fix, un-skip TestComposeGSS#85474
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 3, 2022
Merged
Conversation
Member
|
This change is |
02bded0 to
5fcdf12
Compare
TestComposeGSSTestComposeGSS
044ca2f to
f20dfc2
Compare
4827a90 to
ce10ebe
Compare
* Add `go.mod` file for `pkg/acceptance/compose/gss/psql` for pinning. * Remove dependency on `cockroach` via `pkg/acceptance/compose/gss/psql`. Fixes cockroachdb#84981. Release note: None
ce10ebe to
435642a
Compare
knz
approved these changes
Aug 3, 2022
Contributor
knz
left a comment
There was a problem hiding this comment.
This is very good. 💯 Thanks ricky!
Contributor
|
I'll love to see this backported as far as v21.1 so we can still issue backports for fixes there |
Collaborator
Author
|
bors r=knz |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 435642a to blathers/backport-release-22.1-85474: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go.modfile forpkg/acceptance/compose/gss/psqlfor pinning.cockroachviapkg/acceptance/compose/gss/psql.Fixes #84981.
Release note: None