streamingccl: support sst event in random stream client#85392
streamingccl: support sst event in random stream client#85392craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
| func (r *randomEventGenerator) generateNewEvent() streamingccl.Event { | ||
| var event streamingccl.Event | ||
| if r.numKVEventsSinceLastResolved == r.config.kvsPerCheckpoint && | ||
| r.numKVEventsSinceLastResolved == r.config.sstsPerCheckpoint { |
There was a problem hiding this comment.
Should this be numSSTEventsSinceLastResolved?
83e1ff8 to
6946cc1
Compare
gh-casper
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @miretskiy, @samiskin, and @stevendanna)
pkg/ccl/streamingccl/streamclient/random_stream_client.go line 238 at r1 (raw file):
Previously, stevendanna (Steven Danna) wrote…
Should this be
numSSTEventsSinceLastResolved?
Done. I also changed the logic to generate SST events -- using probability instead of checking num of events generated which may cause bug and is not very intuitive.
Decided to move the delrange x random_stream_client in another PR.
stevendanna
left a comment
There was a problem hiding this comment.
Thanks for adding this! I gave it a once over and it looks good to me.
| WriteTS: sst.WriteTS, | ||
| }) | ||
| default: | ||
| panic("unsopported event type") |
There was a problem hiding this comment.
| panic("unsopported event type") | |
| panic("unsupported event type") |
406e697 to
aa2d95b
Compare
Previously random stream client lacks test coverage for AddSSTable operation, this PR enables random stream client to generate and validate random SSTableEvents. This PR also cleans up the InterceptableStreamClient to avoid unnecessary abstraction, making code cleaner. Release note : None Release justification: low risk, high benefit changes to existing functionality
aa2d95b to
7a8f501
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build failed (retrying...): |
|
Build succeeded: |
Previously random stream client lacks test coverage
for AddSSTable operation, this PR enables random stream
client to generate and validate random SSTableEvents.
This PR also cleans up the InterceptableStreamClient
to avoid unnecessary abstraction, making code cleaner.
Release justification: low risk, high benefit changes to
existing functionality
Release note : None