opt: revert data race fix#85352
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 1, 2022
Merged
Conversation
Member
|
This change is |
DrewKimball
approved these changes
Jul 29, 2022
Collaborator
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @rytaft)
rytaft
approved these changes
Aug 1, 2022
Collaborator
rytaft
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
Collaborator
|
Can you also update the comment above FiltersItem in scalar.opt that says the props are lazily calculated? |
This commit reverts cockroachdb#37972. We no longer lazily build filter props and share them across multiple threads. Release note: None
Contributor
Author
Good catch! Done. TFTRs! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit reverts #37972. We no longer lazily build filter props and
share them across multiple threads.
Release note: None