rfcs: import rollbacks without mvcc timestamps#85338
Closed
msbutler wants to merge 1 commit intocockroachdb:masterfrom
Closed
rfcs: import rollbacks without mvcc timestamps#85338msbutler wants to merge 1 commit intocockroachdb:masterfrom
msbutler wants to merge 1 commit intocockroachdb:masterfrom
Conversation
Currently if an IMPORT writing data into an existing, non-empty cluster fails or is cancelled mid-IMPORT, to roll it back, any rows it had written are found and deleted by scanning the table for rows with a timestamp greater than the time at which the IMPORT started. The reliance on MVCC timestamps during IMPORT rollbacks blocks 1) implementing MVCC AddSSTable for restores of tenants; 2) restoring importing tables. To unblock these important features IMPORT rollbacks should no longer rely on MVCC timestamps. Release note: None
Member
|
This change is |
erikgrinaker
approved these changes
Aug 1, 2022
| import job ID that created the key-value. I.e.: | ||
| ```` message ClientMeta { | ||
|
|
||
| int64 import_job_id = 2 [(gogoproto.customtype) = "JobID"]; |
Contributor
There was a problem hiding this comment.
Suggested change
| int64 import_job_id = 2 [(gogoproto.customtype) = "JobID"]; | |
| int64 import_job_id = 1 [(gogoproto.customtype) = "JobID"]; |
Collaborator
Author
|
closing as design might significantly change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See compiled doc.
Currently if an IMPORT writing data into an existing, non-empty cluster fails
or is cancelled mid-IMPORT, to roll it back, any rows it had written are found
and deleted by scanning the table for rows with a timestamp greater than the
time at which the IMPORT started.
The reliance on MVCC timestamps during IMPORT rollbacks blocks 1)
implementing MVCC AddSSTable for restores of tenants; 2) restoring importing
tables. To unblock these important features, IMPORT rollbacks should no longer
rely on MVCC timestamps.
Release note: None