dev: a couple testlogic improvements#85321
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 30, 2022
Merged
Conversation
Member
|
This change is |
Collaborator
Author
|
Only the second commit needs to be reviewed, the first is from #85284. |
rail
approved these changes
Jul 29, 2022
Member
rail
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
a917550 to
c7b6a5f
Compare
1. Make sure `dev generate testlogic` is documented in `dev generate -h`. 2. Only default to running the sqlite logic tests if `--bigtest` is passed. 3. If a `--config` is passed, check whether the directory exists before running the test. This fixes cases like `dev testlogic --config=local-mixed-21.2-22.1` where not all logic test categories support the config. 4. Warn if no test directories are found. Release note: None
c7b6a5f to
638756f
Compare
Collaborator
Author
|
bors r=rail |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev generate testlogicis documented indev generate -h.--bigtestispassed.
--configis passed, check whether the directory exists beforerunning the test. This fixes cases like
dev testlogic --config=local-mixed-21.2-22.1where not all logictest categories support the config.
Release note: None