dev: add rewritable paths for norm tests#85234
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 29, 2022
Merged
Conversation
Member
|
This change is |
rickystewart
approved these changes
Jul 28, 2022
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build failed: |
Tests in `pkg/sql/opt/norm` are similar to tests in `pkg/sql/opt/xform`
and `pkg/sql/opt/memo` in that they rely on fixtures in
`pkg/sql/opt/testutils/opttester/testfixtures`. This commit adds these
fixtures as rewritable paths for norm tests so that
`./dev test pkg/sql/opt/xform --rewrite` does not fail with errors like:
open pkg/sql/opt/testutils/opttester/testfixtures/tpcc_schema: operation not permitted
Release note: None
Contributor
Author
|
Let's try again. bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests in
pkg/sql/opt/normare similar to tests inpkg/sql/opt/xformand
pkg/sql/opt/memoin that they rely on fixtures inpkg/sql/opt/testutils/opttester/testfixtures. This commit adds thesefixtures as rewritable paths for norm tests so that
./dev test pkg/sql/opt/xform --rewritedoes not fail with errors like:Release note: None