Reviewed 2 of 4 files at r1, 33 of 33 files at r3, 23 of 40 files at r4.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @maryliag and @xinhaoz)

pkg/ui/workspaces/cluster-ui/src/activeExecutions/activeStatementUtils.ts line 99 at r4 (raw file):

            : "Preparing",
        start: TimestampToMoment(query.start),
        elapsedTimeMillis: time.diff(TimestampToMoment(query.start), "ms"),

might be worth just calling elapsedTime and leaving the unit to be generated by the format Duration function, which adds the relevant unit

pkg/ui/workspaces/cluster-ui/src/activeExecutions/activeStatementUtils.ts line 228 at r4 (raw file):

        status: "Executing" as ExecutionStatus,
        start: TimestampToMoment(activeTxn.start),
        elapsedTimeMillis: time.diff(TimestampToMoment(activeTxn.start), "ms"),

same comment as above

pkg/ui/workspaces/cluster-ui/src/activeExecutions/types.ts line 28 at r4 (raw file):

export interface ActiveExecution {
  statementID?: string; // This may not be present for a tranaction.

nit: transaction

pkg/ui/workspaces/cluster-ui/src/detailsPanels/waitTimeInsightsPanel.tsx line 34 at r4 (raw file):

  BLOCKED_INDEX: "Blocked Index",
  BLOCKED_ROW: "Blocked Row",
  WAIT_TIME: "Time Spenet Waiting",

nit: spent

pkg/ui/workspaces/cluster-ui/src/detailsPanels/waitTimeInsightsPanel.tsx line 38 at r4 (raw file):

    `${capitalize(execType)} ID: ${id} waiting on`,
  WAITING_TXNS_TABLE_TITLE: (id: string, execType: ExecutionType): string =>
    `${capitalize(execType)} waiting for ID: ${id}`,

nit: add an s, so it looks like statements waiting for...
you don't need the : on those 2 messages

pkg/ui/workspaces/cluster-ui/src/selectors/activeExecutions.selectors.ts line 30 at r4 (raw file):

// This file contains selector functions used across active execution
// pages that are specific to cluster-ui.
// They should NOT be exported with the cluster-ui package.

I'm a little confused by this comment, this is used for cluster-ui, but should not be exported to cluster-ui, so how cluster-ui is using these functions?

pkg/ui/workspaces/cluster-ui/src/store/clusterLocks/clusterLocks.reducer.ts line 43 at r4 (raw file):

      state.valid = false;
    },
    // Define actions that don't change state

nit: period

pkg/ui/workspaces/cluster-ui/src/store/sessions/sessions.sagas.ts line 46 at r4 (raw file):

    takeLatest(actions.request, requestSessionsSaga),
    takeLatest(
      actions.received,

what was this being used for?

pkg/ui/workspaces/cluster-ui/src/transactionDetails/activeTransactionDetails.tsx line 53 at r4 (raw file):

const TXN_EXECUTION_ID_LABEL = "Transaction Execution ID";

export const GeneralActiveTxnInsightsLabels = {

this is becoming a wordy name, I don't think the general is adding anything here and can be removed

pkg/ui/workspaces/cluster-ui/src/transactionsPage/activeTransactionsView.tsx line 87 at r4 (raw file):

  useEffect(() => {
    // Refresh  every 10 seconds.
    // if (!transactions || transactions.length === 0) {

I think you forgot to put the comment back here

pkg/ui/workspaces/db-console/src/redux/apiReducers.ts line 296 at r4 (raw file):

  api.getSessions,
  "sessions",
  // The sessions page is a real time view, so need a fairly quick update pace.

is this comment still valid since you changed to null?

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)

pkg/ui/workspaces/cluster-ui/src/activeExecutions/activeStatementUtils.ts line 99 at r4 (raw file):

The unit displayed will still be generated by the duration function, I actually made this change so that this would happen (was previously just displaying seconds). I just need to approximate the elapsed time here based on the lastUpdated value since it's not actually returned by the server. We can file that as an issue so as to get a more accurate elapsed time.

pkg/ui/workspaces/cluster-ui/src/activeExecutions/activeStatementUtils.ts line 228 at r4 (raw file):

(responded to other comment)

pkg/ui/workspaces/cluster-ui/src/activeExecutions/types.ts line 28 at r4 (raw file):

Done.

pkg/ui/workspaces/cluster-ui/src/detailsPanels/waitTimeInsightsPanel.tsx line 34 at r4 (raw file):

Done.

pkg/ui/workspaces/cluster-ui/src/detailsPanels/waitTimeInsightsPanel.tsx line 38 at r4 (raw file):

Done.
The : was part of the figma but I can remove it if it makes more sense!

pkg/ui/workspaces/cluster-ui/src/selectors/activeExecutions.selectors.ts line 30 at r4 (raw file):

I noted they shouldn't be exported with the package since they're not to be used in db-console. Since they're local to cluster-ui we don't need to export them since they'll just be used by the components connecting to redux within the pkg. The file activeExecutionsCommon.selectors and the active stmt utils contains the funcs that can be reused across the two pkgs for the selectors and contains all the shared logic in transforming data for the UI pages. This file just uses those functions to create selectors based off the specific state in cluster-ui.

pkg/ui/workspaces/cluster-ui/src/store/clusterLocks/clusterLocks.reducer.ts line 43 at r4 (raw file):

Done.

pkg/ui/workspaces/cluster-ui/src/store/sessions/sessions.sagas.ts line 46 at r4 (raw file):

This was used to perform polling previously (invalidation causes refresh). But since we're manually polling now on the page there's no need for this and I thought the added logic here might muck up the polling being done by the pages so I removed it.

pkg/ui/workspaces/cluster-ui/src/transactionDetails/activeTransactionDetails.tsx line 53 at r4 (raw file):

Done.

pkg/ui/workspaces/cluster-ui/src/transactionsPage/activeTransactionsView.tsx line 87 at r4 (raw file):

Ah yes, fixed!

pkg/ui/workspaces/db-console/src/redux/apiReducers.ts line 296 at r4 (raw file):

Updated comment to better reflect how this api is being used.

I notice on the loom that on the details page, the values for blocked schema, blocked database and blocked index are empty, only the blocked table is populated, is that expected?

Reviewed 1 of 37 files at r5, 36 of 36 files at r6.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @xinhaoz)

pkg/ui/workspaces/cluster-ui/src/detailsPanels/waitTimeInsightsPanel.tsx line 76 at r6 (raw file):

              <Col className="gutter-row" span={12}>
                <SummaryCard className={cx("summary-card")}>
                  <SummaryCardItem

if viewactivityredacted won't have that value, better hide this info on that case.
Similar to showing the column itself, otherwise they will see 0/empty and think there is no contention

@maryliag The DB and schema wasn't being populated in the component at the time I made the loom, that's since been fixed. For all the other values, they are just what is being returned in the query, so the index returned just so happened to be the empty string. Perhaps this is a bug within the virtual table -- I'll ask.

Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @maryliag)

pkg/ui/workspaces/cluster-ui/src/detailsPanels/waitTimeInsightsPanel.tsx line 76 at r6 (raw file):

VIEWACTIVITYREDACTED can show the wait time values and blocked table/schema/db/index, they just won't be able to see which txns are waiting/blocking it. I left it in since I thought it might be useful info -- do you think it's better to just remove everything for REDACTED users?

Thank you for the explanation!

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @xinhaoz)

pkg/ui/workspaces/cluster-ui/src/detailsPanels/waitTimeInsightsPanel.tsx line 76 at r6 (raw file):

ah okay, I thought they couldn't see anything. In that case, makes sense to keep it in