storage: add Writer.PutRawMVCCRangeKey#84962
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 26, 2022
Merged
Conversation
Member
|
This change is |
This patch adds `Writer.PutRawMVCCRangeKey()`, which can be used to write a range key with an already-encoded `MVCCValue`. This is useful to avoid unnecessary decode/encode roundtrips when copying range keys. Release note: None
b13f90c to
ff9f4d3
Compare
jbowens
approved these changes
Jul 25, 2022
Contributor
jbowens
left a comment
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msbutler)
Contributor
Author
|
bors r=jbowens |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch adds
Writer.PutRawMVCCRangeKey(), which can be used towrite a range key with an already-encoded
MVCCValue. This is useful toavoid unnecessary decode/encode roundtrips when copying range keys.
Resolves #84896.
Release note: None