ci: add scripts to build patched versions of Go runtime#84867
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 2, 2022
Merged
ci: add scripts to build patched versions of Go runtime#84867craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
bbd59a5 to
8da42a3
Compare
Collaborator
Author
|
Hmm, still have a failing test. :( |
Contributor
|
I don't entirely understand what's happening and what I'm doing is likely unsound, but this patch fixed the test: diff --git i/pkg/testutils/lint/passes/loopvarcapture/loopvarcapture.go w/pkg/testutils/lint/passes/loopvarcapture/loopvarcapture.go
index 402c8c3fcb..cf919d0bb2 100644
--- i/pkg/testutils/lint/passes/loopvarcapture/loopvarcapture.go
+++ w/pkg/testutils/lint/passes/loopvarcapture/loopvarcapture.go
@@ -51,10 +51,11 @@ var (
// Analyzer implements this linter, looking for loop variables
// captured by reference in closures called in Go routines
Analyzer = &analysis.Analyzer{
- Name: name,
- Doc: doc,
- Requires: []*analysis.Analyzer{inspect.Analyzer},
- Run: run,
+ Name: name,
+ Doc: doc,
+ Requires: []*analysis.Analyzer{inspect.Analyzer},
+ Run: run,
+ RunDespiteErrors: true,
}
// GoRoutineFunctions is a collection of functions that are known toReproduced using: $ ./dev builder
$ ./dev test pkg/testutils/lint/passes/loopvarcaptureFrom what I understand, it's something to do with golang/go#36547, some funkiness in packages.Load expecting metadata for the pseudo C package with some combination of GOOS/CGO_ENABLED env vars. By specifying |
The script simply uses our existing cross toolchains and applies a patch to the Go sources for the fine-grained CPU attribution work. We make a custom `go` executable for all supported platforms except FreeBSD, for which we have no cross-compilers, and M1/M2 Macs, for which we don't have a code-signing pipeline set up yet. Also update `build/README.MD` to capture the new process of building dependencies. Part of cockroachdb#82625. Release note: None
Collaborator
Author
|
I updated the test in question to use a version of the analyzer with |
Collaborator
Author
|
bors r=irfansharif,rail |
Contributor
|
Build failed: |
Collaborator
Author
|
bors r=irfansharif,rail |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The script simply uses our existing cross toolchains and applies a patch
to the Go sources for the fine-grained CPU attribution work. We make a
custom
goexecutable for all supported platforms except FreeBSD, forwhich we have no cross-compilers, and M1/M2 Macs, for which we don't
have a code-signing pipeline set up yet.
Also update
build/README.MDto capture the new process of buildingdependencies.
Part of #82625.
Release note: None