ui: update usages of date range to time interval#84486
ui: update usages of date range to time interval#84486craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
b113c69 to
d877b43
Compare
This commit updates the labels previously saying "date range" to "time interval". This commit also removes an unnecessary tooltip on the "now" button and fix its styling when disabled. Fixes cockroachdb#84361 Release note (ui change): Update of labels from "date range" to "time interval" on time picker (custom option, preset title, previous and next arrows)
d877b43 to
0e3e735
Compare
ericharmeling
left a comment
There was a problem hiding this comment.
LGTM just a small grammar nit you can take or leave
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @maryliag)
pkg/ui/workspaces/cluster-ui/src/timeScaleDropdown/timeFrameControls.tsx line 81 at r1 (raw file):
<Tooltip placement="bottom" title="past 1 day"
nit: remove number in the singular case
Suggestion:
past day
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/timeScaleDropdown/timeFrameControls.tsx line 81 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
nit: remove number in the singular case
When you click on "Now", the time picker change to the value "Past 1 day", so I decided to put the tooltip with the same value displayed there.
What do you think?
ericharmeling
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/timeScaleDropdown/timeFrameControls.tsx line 81 at r1 (raw file):
Previously, maryliag (Marylia Gutierrez) wrote…
When you click on "Now", the time picker change to the value "Past 1 day", so I decided to put the tooltip with the same value displayed there.
What do you think?
You're right; it totally makes sense to keep the tooltip consistent with the value displayed.
IDK if it really matters all that much (it's a really nit-picky thing) but in the future maybe we can change the "Past 1 Hour" and "Past 1 Day" values to "Past Hour" and "Past Day", to be consistent with "Past Week" and "Past Month"?
maryliag
left a comment
There was a problem hiding this comment.
Reviewable status:
pkg/ui/workspaces/cluster-ui/src/timeScaleDropdown/timeFrameControls.tsx line 81 at r1 (raw file):
Previously, ericharmeling (Eric Harmeling) wrote…
You're right; it totally makes sense to keep the tooltip consistent with the value displayed.
IDK if it really matters all that much (it's a really nit-picky thing) but in the future maybe we can change the "Past 1 Hour" and "Past 1 Day" values to "Past Hour" and "Past Day", to be consistent with "Past Week" and "Past Month"?
That's a good idea! I'll keep that for another PR, because I assume we have more places using the format (for tests etc), so we can have a PR dedicated for this change.
|
TFTR! |
|
Build failed (retrying...): |
|
Build succeeded: |
This commit updates the labels previously saying "date range"
to "time interval".
This commit also removes an unnecessary tooltip on the "now"
button and fix its styling when disabled.
Fixes #84361
Release note (ui change): Update of labels from "date range" to
"time interval" on time picker (custom option, preset title, previous
and next arrows)