sql/logictests: don't fail parent test when using retry#84420
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Aug 1, 2022
Merged
sql/logictests: don't fail parent test when using retry#84420craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
testutils.SucceedsSoon calls Fatal() on the passed testing.T. Here,
we were calling SucceedsSoon with the root T, which in the case of a
subtest resulted in this error showing up in our logs
testing.go:1169: test executed panic(nil) or runtime.Goexit:
subtest may have called FailNow on a parent test
This moves to using SucceedsSoonError so that we can process errors
using the same formatting that we use elsewhere.
Release note: None
Member
|
This change is |
Collaborator
Author
|
Bazel failure is #84122 |
Collaborator
Author
|
bors r=knz |
Contributor
|
Build failed: |
Collaborator
Author
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testutils.SucceedsSoon calls Fatal() on the passed testing.T. Here,
we were calling SucceedsSoon with the root T, which in the case of a
subtest resulted in this error showing up in our logs
This moves to using SucceedsSoonError so that we can process errors
using the same formatting that we use elsewhere.
Release note: None