sql/schemachanger: detect unsupported types for unique indexes#84186
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 12, 2022
Merged
sql/schemachanger: detect unsupported types for unique indexes#84186craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
postamar
approved these changes
Jul 11, 2022
| msg := "column %s is of type %s and thus is not indexable" | ||
| typInfo := spec.colType.Type.DebugString() | ||
| msg = fmt.Sprintf(msg, d.Name, spec.colType.Type.Name()) | ||
| panic(unimplemented.NewWithIssueDetailf(35730, typInfo, "%s", msg)) |
There was a problem hiding this comment.
nit: if possible, replace this with
panic(unimplemented.NewWithIssueDetailf(35730, typInfo, msg, d.Name, spec.colType.Type.Name())
so that the error message redactor doesn't redact the whole message into meaninglessness.
| subtest add_column_non_indexable_type | ||
|
|
||
| statement ok | ||
| CREATE TABLE t1_non_indexable(n int); |
There was a problem hiding this comment.
nit: pipe this statement and the one below through sqlfum.pt for nicer formatting
Fixes: cockroachdb#84185 Previously, the declarative schema changer when adding a column with a unique index did not generate the appropriate error when an unsupported type was encountered. As a result, we would wait till execution and require a rollback during execution phase. To address this, this patch will report the unsupported type directly within the builder. Release note: None
fqazi
commented
Jul 11, 2022
Collaborator
Author
fqazi
left a comment
There was a problem hiding this comment.
@postamar TFTR!
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @postamar)
Collaborator
Author
|
bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #84185
Previously, the declarative schema changer when adding
a column with a unique index did not generate the
appropriate error when an unsupported type was encountered.
As a result, we would wait till execution and require a
rollback during execution phase. To address this, this patch
will report the unsupported type directly within the builder.
Release note: None