Skip to content

opt: fix incorrect column indexing in index recommendations#84169

Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom
mgartner:83965-index-rec-fix
Jul 11, 2022
Merged

opt: fix incorrect column indexing in index recommendations#84169
craig[bot] merged 2 commits intocockroachdb:masterfrom
mgartner:83965-index-rec-fix

Conversation

@mgartner
Copy link
Copy Markdown
Contributor

@mgartner mgartner commented Jul 11, 2022

opt: fix incorrect column indexing in index recommendations

Fixes #83965

Release note (bug fix): A minor bug has been fixed that caused internal
errors and poor index recommendations when running EXPLAIN statements.

opt: clarify logic in Metadata.UpdateTableMeta

Release note: None

mgartner added 2 commits July 11, 2022 08:38
@mgartner
opt: fix incorrect column indexing in index recommendations
f678273 
Fixes cockroachdb#83965

Release note (bug fix): A minor bug has been fixed that caused internal
errors and poor index recommendations when running `EXPLAIN` statements.
@mgartner
opt: clarify logic in Metadata.UpdateTableMeta
41a794b 
Release note: None
@mgartner mgartner requested a review from a team as a code owner July 11, 2022 12:45
@cockroach-teamcity
Copy link
Copy Markdown
Member

cockroach-teamcity commented Jul 11, 2022

This change is Reviewable

@mgartner mgartner requested review from cucaroach and rytaft July 11, 2022 12:45
@mgartner mgartner mentioned this pull request Jul 11, 2022
Closed
@mgartner mgartner requested review from msirek and wenyihu6 and removed request for cucaroach July 11, 2022 12:52
msirek
msirek approved these changes Jul 11, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@msirek msirek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rytaft and @wenyihu6)

@mgartner
Copy link
Copy Markdown
Contributor Author

mgartner commented Jul 11, 2022

TFTR!

bors r+

@mgartner
Copy link
Copy Markdown
Contributor Author

mgartner commented Jul 11, 2022

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 11, 2022

Build succeeded:

@craig craig bot merged commit 10853d2 into cockroachdb:master Jul 11, 2022
@blathers-crl
Copy link
Copy Markdown

blathers-crl bot commented Jul 11, 2022

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.

error creating merge commit from f678273 to blathers/backport-release-22.1-84169: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan.

@mgartner mgartner deleted the 83965-index-rec-fix branch July 11, 2022 21:57
@mgartner mgartner mentioned this pull request Jul 11, 2022
Merged
@yuzefovich yuzefovich mentioned this pull request Aug 2, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rytaft rytaft Awaiting requested review from rytaft

@wenyihu6 wenyihu6 Awaiting requested review from wenyihu6

1 more reviewer

@msirek msirek msirek approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Crashing by EXPLAIN Statement

3 participants

@mgartner @cockroach-teamcity @msirek