Revert "kvstreamer: reuse incomplete Get requests on resume batches"#84143
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 11, 2022
Merged
Revert "kvstreamer: reuse incomplete Get requests on resume batches"#84143craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
This reverts commit 21f2390. Previously, I didn't realize that the KV layer would modify all requests included into the BatchRequest in `txnSeqNumAllocator`, so we cannot reuse even incomplete GetRequests. It is unfortunate, but not a big deal. Release note: None
michae2
approved these changes
Jul 11, 2022
Collaborator
michae2
left a comment
There was a problem hiding this comment.
Oh well, good try. 🙂
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
Member
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 21f2390.
Previously, I didn't realize that the KV layer would modify all requests
included into the BatchRequest in
txnSeqNumAllocator, so we cannotreuse even incomplete GetRequests. It is unfortunate, but not a big
deal.
Fixes: #83974.
Release note: None