bazel: clear configurations when running git grep in check.sh#84015
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 7, 2022
Merged
bazel: clear configurations when running git grep in check.sh#84015craig[bot] merged 1 commit intocockroachdb:masterfrom
git grep in check.sh#84015craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
The configurations `grep.{column,lineNumber,fullName}` can be set
globally or on a per-user basis and change the output of `git grep`,
which breaks checks that do exact-string matching. We manually clear
these configurations for the `git grep`s in this file to ensure the
output is predictable on any machine.
Release note: None
Member
|
This change is |
miretskiy
approved these changes
Jul 7, 2022
mari-crl
approved these changes
Jul 7, 2022
Contributor
mari-crl
left a comment
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @rickystewart)
Collaborator
Author
|
bors r=miretskiy,mari-crl |
Contributor
|
Build succeeded: |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The configurations
grep.{column,lineNumber,fullName}can be setglobally or on a per-user basis and change the output of
git grep,which breaks checks that do exact-string matching. We manually clear
these configurations for the
git greps in this file to ensure theoutput is predictable on any machine.
Release note: None