Skip to content

streamingccl: small logging and tracing cleanups#83979

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
stevendanna:ssd/another-tracing-span
Jul 7, 2022
Merged

streamingccl: small logging and tracing cleanups#83979
craig[bot] merged 1 commit intocockroachdb:masterfrom
stevendanna:ssd/another-tracing-span

Conversation

@stevendanna
Copy link
Copy Markdown
Collaborator

  • Add a tracing span to ingestion job cutover.
  • Move a particularly noisy log message to VInfo(3).
  • Prefer log.VInfo to if log.V(n) {} in cases where we aren't doing
    expensive argument construction.

Release note: None

- Add a tracing span to ingestion job cutover.
- Move a particularly noisy log message to VInfo(3).
- Prefer log.VInfo to `if log.V(n) {}` in cases where we aren't doing
  expensive argument construction.

Release note: None
@stevendanna stevendanna requested a review from miretskiy July 7, 2022 11:43
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@stevendanna stevendanna requested a review from gh-casper July 7, 2022 11:43
@stevendanna
Copy link
Copy Markdown
Collaborator Author

bors r=miretskiy

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 7, 2022

Build succeeded:

@craig craig bot merged commit bce2267 into cockroachdb:master Jul 7, 2022
@shermanCRL shermanCRL added the A-tenant-streaming Including cluster streaming label Jul 29, 2022
@shermanCRL shermanCRL added this to the 22.2 milestone Jul 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-tenant-streaming Including cluster streaming

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants