streamingccl: unskip TestTenantStreaming#83975
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 7, 2022
Merged
Conversation
This makes a couple of changes aimed at unskipping TestTenantStreaming: - Fix a nil pointer access in our stream status verification function. We changed the name of key that this function was accessing. This NPE was hidden by another panic along the unclean shutdown path in the server. - Lower various intervals so that this test doesn't take 90 seconds. I've run this under stress for a few hundred iterations without error. Release note: None
Member
|
This change is |
miretskiy
approved these changes
Jul 7, 2022
Collaborator
Author
|
bors r=miretskiy |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes a couple of changes aimed at unskipping
TestTenantStreaming:
Fix a nil pointer access in our stream status verification
function. We changed the name of key that this function was
accessing. This NPE was hidden by another panic along the unclean
shutdown path in the server.
Lower various intervals so that this test doesn't take 90 seconds.
I've run this under stress for a few hundred iterations without error.
Release note: None