coexec: normalize the timestamp subtraction like postgres#83944
coexec: normalize the timestamp subtraction like postgres#83944craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
|
This change is |
This commit fixes an oversight of cockroachdb#56667 (which fixed the normalization of the timestamp subtraction) where we forgot to update the vectorized code path as well. The regression tests added in that PR happened to be complex enough so that the vectorized engine would fall back to wrapping a row-by-row processor, so they didn't catch this. Release note (bug fix): CockroachDB previously would not normalize `timestamp/timestamptz - timestamp/timestamptz` like Postgres does in some cases (depending on the query), and this is now fixed.
DrewKimball
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @msirek)
|
TFTRs! bors r+ |
|
Build failed (retrying...): |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 52737fb to blathers/backport-release-21.2-83944: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 21.2.x failed. See errors above. error creating merge commit from 52737fb to blathers/backport-release-22.1-83944: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
This commit fixes an oversight of #56667 (which fixed the normalization
of the timestamp subtraction) where we forgot to update the vectorized
code path as well. The regression tests added in that PR happened to be
complex enough so that the vectorized engine would fall back to wrapping
a row-by-row processor, so they didn't catch this.
Fixes: #83094.
Release note (bug fix): CockroachDB previously would not normalize
timestamp/timestamptz - timestamp/timestamptzlike Postgres does insome cases (depending on the query), and this is now fixed.