outliers: protocol buffer adjustments#83943
Merged
craig[bot] merged 5 commits intocockroachdb:masterfrom Jul 7, 2022
matthewtodd:outliers-protos
Merged
outliers: protocol buffer adjustments#83943craig[bot] merged 5 commits intocockroachdb:masterfrom matthewtodd:outliers-protos
craig[bot] merged 5 commits intocockroachdb:masterfrom
matthewtodd:outliers-protos
Conversation
added 5 commits
July 6, 2022 17:47
I started off nesting them, but the generated Go code felt unnecessarily noisy. Note that these are safe moves because these messages are neither persisted nor sent over the wire yet. Release note: None
This helps set us up for the asynchronous work in #81021, making these objects earlier so we can keep them around in buffers until we're ready to process them. Release note: None
It's nicer having a type instead of those raw bytes. Release note: None
It's nicer having a type instead of those raw bytes. Release note: None
Release note: None
Member
|
This change is |
THardy98
approved these changes
Jul 7, 2022
THardy98
left a comment
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, 5 of 5 files at r2, 6 of 6 files at r3, 6 of 6 files at r4, 5 of 5 files at r5, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @matthewtodd)
Author
|
bors r+ |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This handful of commits slightly re-shapes the protocol buffer messages we use for tracking outliers, making some of the work in #81021 a little easier to express.