storage: clarify and test overlapping SST range keys in Export#83927
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 7, 2022
Merged
storage: clarify and test overlapping SST range keys in Export#83927craig[bot] merged 1 commit intocockroachdb:masterfrom
Export#83927craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This patch clarifies that an `Export` with overlapping MVCC range tombstones across two SSTs due to `SplitMidKey` will be handled correctly both by multiplexed iteration with `NewPebbleSSTIterator()`, and by `AddSSTable`. Release note: None
Member
|
This change is |
nicktrav
approved these changes
Jul 6, 2022
Collaborator
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aliher1911 and @sumeerbhola)
Contributor
Author
|
TFTR! bors r=nicktrav |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch clarifies that an
Exportwith overlapping MVCC rangetombstones across two SSTs due to
SplitMidKeywill be handledcorrectly both by multiplexed iteration with
NewPebbleSSTIterator(),and by
AddSSTable.Release note: None