roachprod: fix target path when getting cluster artifacts.#83923
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 7, 2022
Merged
roachprod: fix target path when getting cluster artifacts.#83923craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
A bug was introduced in the computation of the local path where cluster artifacts are downloaded: instead of prefixing the path with the node ID, the list of nodes would be used instead. This results in (other than weird looking paths, such as `[1 2 3 4].logs`) only the logs for the last node being downloaded. This commit fixes the issue by using the node ID correctly. Release note: None.
Member
|
This change is |
Author
|
Using Tobi's reproduction steps on this branch: |
srosenberg
approved these changes
Jul 6, 2022
Author
|
bors r=srosenberg |
Contributor
|
Build failed (retrying...): |
Contributor
|
Build succeeded: |
30 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A bug was introduced in the computation of the local path where
cluster artifacts are downloaded: instead of prefixing the path with
the node ID, the list of nodes would be used instead. This results
in (other than weird looking paths, such as
[1 2 3 4].logs) only thelogs for the last node being downloaded.
This commit fixes the issue by using the node ID correctly.
Release note: None.