Skip to content

asim: update range size split threshold, more keys#83827

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
kvoli:220705.asim-default-split
Jul 11, 2022
Merged

asim: update range size split threshold, more keys#83827
craig[bot] merged 1 commit intocockroachdb:masterfrom
kvoli:220705.asim-default-split

Conversation

@kvoli
Copy link
Copy Markdown
Contributor

@kvoli kvoli commented Jul 5, 2022

This patch updates the range size split threshold to 512mb by default.
Additionally it adds support for initializing a testing replica
distribution, where the ranges contain an equal span of the keyspace.

Release note: None

@kvoli kvoli requested review from lidorcarmel and shralex July 5, 2022 18:08
@kvoli kvoli self-assigned this Jul 5, 2022
@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@kvoli kvoli removed request for lidorcarmel and shralex July 5, 2022 18:48
@kvoli kvoli force-pushed the 220705.asim-default-split branch from f445b23 to 5218081 Compare July 5, 2022 22:48
This patch updates the range size split threshold to 512mb by default.
Additionally it adds support for initializing a testing replica
distribution, where the ranges contain an equal span of the keyspace.

Release note: None
@kvoli kvoli force-pushed the 220705.asim-default-split branch from 5218081 to 28f5627 Compare July 5, 2022 22:49
@kvoli kvoli marked this pull request as ready for review July 5, 2022 22:49
@kvoli kvoli requested a review from a team as a code owner July 5, 2022 22:49
@kvoli kvoli requested a review from lidorcarmel July 6, 2022 04:24
Copy link
Copy Markdown
Contributor

@lidorcarmel lidorcarmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @kvoli)

@kvoli
Copy link
Copy Markdown
Contributor Author

kvoli commented Jul 11, 2022

Bors r+

@craig craig bot merged commit bef1101 into cockroachdb:master Jul 11, 2022
@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jul 11, 2022

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants