Skip to content

ui: improve tooltip UX with text updates#83420

Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom
ericharmeling:tooltip-fixes
Jun 28, 2022
Merged

ui: improve tooltip UX with text updates#83420
craig[bot] merged 1 commit intocockroachdb:masterfrom
ericharmeling:tooltip-fixes

Conversation

@ericharmeling
Copy link
Copy Markdown

@ericharmeling ericharmeling commented Jun 27, 2022

Fixes #81374.
Fixes #83256.
Fixes #81248.
Fixes #79018.

Note the following:

Release note (ui change): Updated tooltips on the Statements and
Transactions pages in the DB Console for improved UX.

@cockroach-teamcity
Copy link
Copy Markdown
Member

This change is Reviewable

@ericharmeling ericharmeling requested a review from a team June 27, 2022 16:31
Copy link
Copy Markdown
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smaller nit on your commit message, otherwise :lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling and @maryliag)


-- commits line 3 at r1:
nit: your commit message should also have the "Fixes..."

your release note should state there were updates on tooltips

Copy link
Copy Markdown
Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @maryliag)


-- commits line 3 at r1:

Previously, maryliag (Marylia Gutierrez) wrote…

nit: your commit message should also have the "Fixes..."

your release note should state there were updates on tooltips

Fixed!

Fixes cockroachdb#81374.
Fixes cockroachdb#83256.
Fixes cockroachdb#81248.
Fixes cockroachdb#79018.

Release note (ui change): Updated tooltips on the Statements and
Transactions pages in the DB Console for improved UX.
@ericharmeling
Copy link
Copy Markdown
Author

bors r+

@craig
Copy link
Copy Markdown
Contributor

craig bot commented Jun 28, 2022

Build succeeded:

@ghost
Copy link
Copy Markdown

ghost commented Jul 13, 2022

@ericharmeling, @maryliag I'm reverting date range to time interval throughout in the docs. If we no longer want to use date range, shouldn't this UX label be updated as well?

See filed issue #84361

@ericharmeling
Copy link
Copy Markdown
Author

I'm reverting date range to time interval throughout in the docs. If we no longer want to use date range, shouldn't this UX label be updated as well?

See filed issue #84361

I believe so. Thank you for pointing that out and for filing an issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants