batcheval: support MVCC range tombstones in AddSSTable#83404
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jul 1, 2022
Merged
batcheval: support MVCC range tombstones in AddSSTable#83404craig[bot] merged 2 commits intocockroachdb:masterfrom
AddSSTable#83404craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
4680207 to
bf2450f
Compare
bf2450f to
57cc3f3
Compare
This patch allows callers to pass `IterOptions` for the new SST iterators. Release note: None
This patch adds initial support for MVCC range tombstones in `AddSSTable`, allowing ingestion of SSTs with such tombstones. Callers must check the `MVCCRangeTombstones` version gate before writing them. They are not yet supported with `DisallowConflicts`, `DisallowShadowing`, and `DisallowShadowingBelow` (including checking for conflicts with existing range tombstones), and will error if an SST contains any MVCC range tombstone. This is not needed for the initial cluster replication use-case, and proper support would require MVCC stats support for range tombstones as well -- this will be implemented later. Release note: None
57cc3f3 to
4591c7f
Compare
Contributor
Author
|
TFTR! bors r=aliher1911 |
Contributor
|
Build failed: |
Contributor
Author
|
bors retry |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storage: expose
IterOptionsfor SST iteratorsThis patch allows callers to pass
IterOptionsfor the new SSTiterators.
Release note: None
batcheval: support MVCC range tombstones in
AddSSTableThis patch adds initial support for MVCC range tombstones in
AddSSTable, allowing ingestion of SSTs with such tombstones. Callersmust check the
MVCCRangeTombstonesversion gate before writing them.They are not yet supported with
DisallowConflicts,DisallowShadowing, andDisallowShadowingBelow(including checkingfor conflicts with existing range tombstones), and will error if an SST
contains any MVCC range tombstone. This is not needed for the initial
cluster replication use-case, and proper support would require MVCC
stats support for range tombstones as well -- this will be implemented
later.
Resolves #76234.
Release note: None