storage: use new pebble.CloneOptions when cloning iterators#82981
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jul 12, 2022
Merged
storage: use new pebble.CloneOptions when cloning iterators#82981craig[bot] merged 1 commit intocockroachdb:masterfrom
pebble.CloneOptions when cloning iterators#82981craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
1ad434d to
437ccd2
Compare
jbowens
approved these changes
Jun 30, 2022
Contributor
jbowens
left a comment
There was a problem hiding this comment.
the new CloneOptions (and the fix for the bug that you ran into when testing this previously) have landed on master.
Reviewed 2 of 5 files at r1, 2 of 3 files at r3, 1 of 1 files at r4.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @erikgrinaker)
This patch avoids first cloning and then reconfiguring the cloned iterator, by constructing the clone with the correct settings in the first place. This shows a slight improvement on `MVCCGet` benchmarks that were modified to always use cloned iterators. This would also happen normally in many cases (e.g. when using an intent interleaving iterator with a raw `Engine`, or when constructing a time-bound iterator which requires two iterators from the underlying reader). ``` MVCCGet_Pebble/batch=false/versions=1/valueSize=8-24 4.87µs ± 3% 4.82µs ± 2% ~ (p=0.101 n=10+10) MVCCGet_Pebble/batch=false/versions=10/valueSize=8-24 5.88µs ± 1% 5.83µs ± 0% -0.94% (p=0.004 n=10+9) MVCCGet_Pebble/batch=false/versions=100/valueSize=8-24 13.7µs ± 6% 13.7µs ± 4% ~ (p=0.971 n=10+10) MVCCGet_Pebble/batch=true/versions=1/valueSize=8-24 2.76µs ± 1% 2.76µs ± 1% ~ (p=0.871 n=10+10) MVCCGet_Pebble/batch=true/versions=10/valueSize=8-24 3.89µs ± 1% 3.86µs ± 2% -0.76% (p=0.011 n=10+10) MVCCGet_Pebble/batch=true/versions=100/valueSize=8-24 10.2µs ± 3% 10.2µs ± 4% ~ (p=0.912 n=10+10) ``` Release note: None
437ccd2 to
c58c0aa
Compare
nicktrav
approved these changes
Jul 11, 2022
Collaborator
nicktrav
left a comment
There was a problem hiding this comment.
Reviewed 7 of 7 files at r5, all commit messages.
Reviewable status:
Contributor
Author
|
TFTRs! bors r=jbowens,nicktrav |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch avoids first cloning and then reconfiguring the cloned
iterator, by constructing the clone with the correct settings in the
first place.
This shows a slight improvement on
MVCCGetbenchmarks that weremodified to always use cloned iterators. This would also happen
normally in many cases (e.g. when using an intent interleaving iterator
with a raw
Engine, or when constructing a time-bound iterator whichrequires two iterators from the underlying reader).
Release note: None