kv: extract etcd/raft utilities into raftutil library#82797
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 13, 2022
Merged
kv: extract etcd/raft utilities into raftutil library#82797craig[bot] merged 1 commit intocockroachdb:masterfrom
craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
This commit extracts some scattered logic to interpret the state of an etcd/raft Status into a new `raftutil` library. The library initially has two functions: `ReplicaIsBehind` and `ReplicaMayNeedSnapshot`. In the future, I expect that we'll extract more helper functions that make working with etcd/raft easier into this library.
Member
|
This change is |
knz
approved these changes
Jun 12, 2022
Contributor
knz
left a comment
There was a problem hiding this comment.
Nice refactor.
Reviewed 13 of 13 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @irfansharif)
erikgrinaker
approved these changes
Jun 13, 2022
Contributor
erikgrinaker
left a comment
There was a problem hiding this comment.
Appreciate the extra tests too.
Contributor
Author
|
TFTRs! bors r+ |
Contributor
|
Build failed: |
Contributor
Author
Docker hub flake. bors r+ |
irfansharif
approved these changes
Jun 13, 2022
Contributor
|
This PR was included in a batch that was canceled, it will be automatically retried |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit pulled from #82758.
This commit extracts some scattered logic to interpret the state of an
etcd/raftStatus into a newraftutillibrary. The library initially has two functions:ReplicaIsBehindandReplicaMayNeedSnapshot. In the future, I expect that we'll extract more helper functions that make working withetcd/rafteasier into this library.