sql, pgwire: Add SEVERITY_NONLOCALIZED error field#82677
sql, pgwire: Add SEVERITY_NONLOCALIZED error field#82677craig[bot] merged 1 commit intocockroachdb:masterfrom
SEVERITY_NONLOCALIZED error field#82677Conversation
|
This change is |
rafiss
left a comment
There was a problem hiding this comment.
the code looks good! could you update the tests with
./dev test pkg/sql/pgwire --filter='TestPGTest/notice' --rewrite
also, can you make the release note be (sql change) and mention that we now send the SeverityUnlocalized field in the pgwire NoticeResponse.
pkg/sql/pgwire/pgerror/errors.proto
Outdated
| string hint = 4; | ||
| string severity = 8; | ||
| string constraint_name = 9; | ||
| string severity_nonlocalized = 9; |
There was a problem hiding this comment.
oh interesting, didn't realize this would need to change
the important thing about proto definitions is that the order matters. if you change the order, it changes how the object is serialized, which means code that is using the old definition won't know how to deserialize it
so, you need to make severity_nonlocalized be at number 10
There was a problem hiding this comment.
Just realized this was left over code I meant to remove.
Release note (sql change): We now send the Severity_Nonlocalized field in the pgwire Notice Response.
|
bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from ea6ded2 to blathers/backport-release-22.1-82677: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
Resolves #81794
Release note (sql change): We now send the Severity_Nonlocalized field
in the pgwire Notice Response.