sql: removed redundant parameter in method to schedule sql stats compaction#82560
Conversation
|
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
This change is |
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rafiss and @surahman)
-- commits line 4 at r1:
please update the commit message:
title should begin with sql: removed parameter from ...
the release note should begin with Release note (sql change):
the release note message is confusing right now, since it makes it seem like the function was removed.
maryliag
left a comment
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1.
Reviewable status:
pkg/sql/sem/builtins/builtins.go line 6538 at r1 (raw file):
Previously, rafiss (Rafi Shamim) wrote…
cc @cockroachdb/sql-observability is there any frontend page that calls this function? if so, we'd have to make sure that this change is OK to make.
No, frontend pages don't make any calls to this function
e7ed582 to
8e87552
Compare
|
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is otan. |
|
@rafiss all requested changes have been affected. |
8e87552 to
25c3dfd
Compare
crdb_internal.schedule_sql_stats_compaction25c3dfd to
0bc7213
Compare
rafiss
left a comment
There was a problem hiding this comment.
Reviewable status:
-- commits line 5 at r3:
nit: this note would be more clear to readers if youo mentioned the function name specifically.
"The byte string parameter in the crdb_internal.schedule_sql_stats_compaction function has been removed."
0bc7213 to
b9e1fc3
Compare
…action Release note (sql change): The byte string parameter in the crdb_internal.schedule_sql_stats_compaction function has been removed.
b9e1fc3 to
5d57e0f
Compare
rafiss
left a comment
There was a problem hiding this comment.
thanks for your contribution!
bors r+
|
Build succeeded: |
The
crdb_internal.schedule_sql_stats_compactionSQL function does not require thebytestring parameter and has thus been removed. Closes #78332.Jira issue: CRDB-14071
@Azhng