bazel: add more detail to dev test cobra msg#82482
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 8, 2022
Merged
bazel: add more detail to dev test cobra msg#82482craig[bot] merged 1 commit intocockroachdb:masterfrom
dev test cobra msg#82482craig[bot] merged 1 commit intocockroachdb:masterfrom
Conversation
Member
|
This change is |
Collaborator
Author
|
If I rerun |
Collaborator
|
@msbutler |
rickystewart
requested changes
Jun 6, 2022
Collaborator
rickystewart
left a comment
There was a problem hiding this comment.
Nit: detail in the commit message, not detial.
dev test cobra msgdev test cobra msg
rickystewart
approved these changes
Jun 7, 2022
b05eec4 to
c3236b9
Compare
irfansharif
approved these changes
Jun 7, 2022
Contributor
irfansharif
left a comment
There was a problem hiding this comment.
LGTM, appended a cosmetic commit to unify how the help text looks across dev test -h and dev bench -h -- feel free to drop it.
msbutler
commented
Jun 7, 2022
msbutler
commented
Jun 7, 2022
c3236b9 to
e3c645d
Compare
b0af956 to
46670b0
Compare
irfansharif
approved these changes
Jun 8, 2022
Contributor
irfansharif
left a comment
There was a problem hiding this comment.
Thanks Michael, this will really help!
Fixes cockroachdb#82411 Release note: None
Collaborator
Author
|
bors r=irfansharif, rickystewart |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #82411
Release note: None