sql/sem/builtins: remove dependency of builtins on sql/catalog/descs#82433
Merged
craig[bot] merged 1 commit intocockroachdb:masterfrom Jun 6, 2022
Merged
Conversation
Member
|
This change is |
This was referenced Jun 3, 2022
025c290 to
5d34ec7
Compare
otan
reviewed
Jun 6, 2022
5d34ec7 to
7f2d57d
Compare
92c5518 to
e40a145
Compare
yuzefovich
reviewed
Jun 6, 2022
Member
yuzefovich
left a comment
There was a problem hiding this comment.
Did a quick scroll through, LGTM, but I'll defer to Oliver for approval. Thanks for cleaning this up!
Reviewed 19 of 19 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @otan)
otan
approved these changes
Jun 6, 2022
builtins is a major bottleneck in the build graph. Reducing its deps helps move it to be earlier. This removes effectively all dependencies on the subtree under catalog. The introduction of the new package was required to eliminate the very upsetting method to return a descriptor as an opaque interface. Release note: None
e40a145 to
0a3137c
Compare
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
builtins is a major bottleneck in the build graph. Reducing its deps helps
move it to be earlier. This removes effectively all dependencies on the
subtree under catalog. The introduction of the new package was required to
eliminate the very upsetting method to return a descriptor as an opaque
interface.
Release note: None