sql/multiregion: move telemetry names to break catpb->tree dep#82432
Merged
craig[bot] merged 2 commits intocockroachdb:masterfrom Jun 6, 2022
Merged
sql/multiregion: move telemetry names to break catpb->tree dep#82432craig[bot] merged 2 commits intocockroachdb:masterfrom
craig[bot] merged 2 commits intocockroachdb:masterfrom
Conversation
Member
|
This change is |
fe16ad1 to
f2a584a
Compare
It was a bottleneck in the build graph. Release note: None
f2a584a to
f822f9e
Compare
f822f9e to
639e5e3
Compare
chengxiong-ruan
approved these changes
Jun 6, 2022
Contributor
chengxiong-ruan
left a comment
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @RichardJCai)
RichardJCai
approved these changes
Jun 6, 2022
Contributor
RichardJCai
left a comment
There was a problem hiding this comment.
Looked at privilege commit, LGTM
This is required to break the dependency from catpb on tree. Doing so should improve build times and generally provide a bit more cleanliness in the dependency graph. Release note: None
639e5e3 to
a6e285d
Compare
Contributor
Author
|
TFTR! bors r+ |
Contributor
|
Build succeeded: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It was a bottleneck in the build graph. See individual commits.
Release note: None